From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 04 Aug 2008 08:05:56 GMT
Subject: Re: [PATCH] Git.pm: Fix internal git_command_bidi_pipe() users
Message-ID: <7vtze12oij.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080804075313.21325.28396.stgit@localhost>

Petr Baudis <pasky@suse.cz> writes:

> The hash_and_insert_object() and cat_blob() helpers were using
> an incorrect slice-from-ref Perl syntax. This patch fixes that up
> in the _close_*() helpers and make the _open_*() helpers use the
> same syntax for consistnecy.
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>
> ---
>
>   Wow, the command_bidi_pipe API really is dirty. Of course, it is
> my fault as anyone's since I didn't get around to review the patches
> introducing it.

Sorry, delete is still broken with your patch, isn't it?

The earlier patch from Abhijit Menon-Sen does this properly for
close_hash_and_insert and close_cat_blob, which I've queued already.