From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 02 May 2009 11:56:28 GMT
Subject: Re: [PATCH] git-svn testsuite: use standard configuration for Subversion tools
Message-ID: <7vtz437m6r.fsf@alter.siamese.dyndns.org>
In-Reply-To: <GzXVCxlG1vigUEGxhNBLVXNYljM@AnOk+mYbmYVORDu5SWQWxomMUcc>

Eygene Ryabinkin <rea-git@codelabs.ru> writes:

>> > What are your concerns, 'local'?
>> 
>> Exactly.
>
> It exists in Bash and in *BSD /bin/sh.  It does not exist in Korn shell
> (at least, I am failing to find one).  I can just remove 'local' from
> the function, since it plays no big role, but generally I don't like to
> pollute parent namespace by local variables.  Certainly, if 'local' will
> break some known shell -- I'll refrain from using it in this script.

Yup, please.  This is "it is not even in POSIX, so let's not use it"
category.