From: Junio C Hamano Date: Tue, 12 May 2009 08:12:14 GMT Subject: Re: [PATCHv2 2/2] completion: complete config variables for --get/getall/unset/unset-all Message-ID: <7vtz3q91up.fsf@alter.siamese.dyndns.org> In-Reply-To: <4A09071A.1030107@gmail.com> Stephen Boyd writes: > Shawn O. Pearce wrote: >> These probably could have been one patch, since the function >> is introduced only to support this one usage, and this patch >> is only 4 lines larger than the function definition anyway... > > Seeing that this hasn't been picked up yet, I'm fine with this being > squashed into one commit. Could you use this combination of the two > messages for the commit? > > ---8<---- > > Subject: completion: complete config variables for > --get/getall/unset/unset-all Hmm, shouldn't this just be Subject: completion: complete variable names for "git config" command ?