From: Junio C Hamano Date: Thu, 23 Jul 2009 05:13:33 GMT Subject: Re: Performance issue of 'git branch' Message-ID: <7vtz1456de.fsf@alter.siamese.dyndns.org> In-Reply-To: Linus Torvalds writes: > On Wed, 22 Jul 2009, Linus Torvalds wrote: >> >> But I'll see if I can dig up my non-binary-search patch and see if I can >> make it go faster. My machine is fast, but not so fast that I can't >> measure it ;) > > Oh. We actually merged a fixed version of it. I'd completely forgotten. As the commit message of 628522e (sha1-lookup: more memory efficient search in sorted list of SHA-1, 2007-12-29) shows, it didn't get any great performance improvements, even though it did make the probing quite a lot less memory intensive. Perhaps you can spot obvious inefficiency in the code that I failed to see, just like you recently did for "show --cc" codepath?