From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Nov 2009 00:06:07 GMT
Subject: Re: [PATCH] log --format: document %w
Message-ID: <7vtywmayvk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B09CD5A.4070401@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> I think utf8_width() is too generic for that; we shouldn't teach it terminal
> control details.

I agree that the function whose purpose is to compute display width should
not be called utf8_width().

The outside caller of utf8_width() in diff.c uses it to truncate the
function name hint on the hunk header line at character boundary.  The
input shouldn't have color escapes _we_ add (it might contain such
sequences from the user data, though), so I agree that we shouldn't
contaminate this function with color escapes.

> strbuf_add_wrapped_text(); ignoring display mode escape codes in there can be
> justified with its purpose.

Surely, and thanks.  The patch looks good.