From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Nov 2009 18:27:24 GMT
Subject: Re: [PATCH] unset GREP_OPTIONS in test-lib.sh
Message-ID: <7vtywlyu43.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091123112221.GA7175@sajinet.com.pe>

Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe> writes:

> why not better to apply the proposed patch from Junio in :
>
>   http://article.gmane.org/gmane.comp.version-control.git/127980/
>
> it would IMHO correct all reported issues and serve as well as a catch
> all from other tools that could be introduced in the future and that
> will be similarly affected by this misfeature.

I think René's patch is more sensible than $gmane/127980 because we have
no business mucking with these environment variables when we are running
things other than external grep.  You could be using system's "grep" in
your pre-commit hook to find some stuff, and your hook either may rely
on your having a particular set of GREP_OPTIONS in your environment, or
may be designed to work well with GREP_OPTIONS.