From: Junio C Hamano Date: Tue, 09 Feb 2010 03:55:49 GMT Subject: Re: [PATCH] blame: prevent a segv when -L given start > EOF Message-ID: <7vtytrrrju.fsf@alter.siamese.dyndns.org> In-Reply-To: <1265687293-11168-1-git-send-email-jaysoffian@gmail.com> Jay Soffian writes: > - if (lno < top) > + if (lno < top || lno < bottom) > die("file %s has only %lu lines", path, lno); Thanks; I think we make sure that "bottom < top" always hold true before we reach this point, so checking with bottom alone should suffice, no?