From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 Apr 2010 21:13:18 GMT
Subject: Re: log --pretty/--oneline: ignore log.decorate
Message-ID: <7vtyrl4pht.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100408194237.GA4222@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Subject: [PATCH] script with rev-list instead of log
>
> Because log.decorate now shows decorations for --pretty=oneline,
> we must explicitly turn it off when scripting. Otherwise,
> users with log.decorate set will get cruft like:
>
>   $ git stash
>   Saved working directory and index state WIP on master:
>     2c1f7f5 (HEAD, master) commit subject
>
> Instead of adding --no-decorate to the log command line,
> let's just use the rev-list plumbing interface instead,
> which does the right thing.
>
> git-submodule has a similar call. Since it just counts the
> commit lines, nothing is broken, but let's switch it, too,
> for the sake of consistency and cleanliness.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I think these changes are Obviously Correct (tm)

Looks good; thanks.