From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 08 Jun 2010 21:05:30 GMT
Subject: Re: permissions
Message-ID: <7vtypds09x.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTimAmSxq8dC-4bnpLsvN3JabQeTO6pDTh9ds7D0D@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

> On Tue, Jun 8, 2010 at 12:25, William Pursell <bill.pursell@gmail.com> wrote:
>> Here's a patch.  This doesn't address the issue of a damaged
>> repository, but just catches access errors and permissions.
>
> The change looks fishy.
>
> The patch moves the function is_git_directory at the level of user
> interface where it wasn't before: it now complains and die.
> Not all callers of the function call it only to die if it fails.

Thanks for shooting it down before I had to look at it ;-)