From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Sep 2010 22:20:02 GMT
Subject: Re: [PATCH 5/6] tree_entry_interesting(): remove dependency on struct diff_options
Message-ID: <7vtylavnfx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1284938514-16663-6-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> This function can be potentially used in more places than just
> tree-diff.c. "struct diff_options" does not make much sense outside
> diff_tree_sha1().

This does a bit more than that; it does not call tree_entry_extract()
anymore, and instead uses the knowledge of its underlying implementation.
The mode of the entry that is passed to S_ISDIR() check is not cleansed
with canon_mode() anymore.

I do not think these are necessarily bad changes, but they should be
documented.