From: Junio C Hamano Date: Thu, 23 Feb 2012 01:00:12 GMT Subject: Re: [PATCHv3 3/5] tag --exclude option Message-ID: <7vty2i749v.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120223002215.GE2410@tgrennan-laptop> Tom Grennan writes: > On Tue, Feb 21, 2012 at 10:33:29PM -0800, Junio C Hamano wrote: > >>As you do not specify what kind of pattern matching is done to this >>exclude pattern, it is important to use the same logic between positive >>and negative ones to give users a consistent UI. Unfortunately we use >>fnmatch without FNM_PATHNAME for positive ones, so this exclude pattern >>needs to follow the same semantics to reduce confusion. >> >>This comment applies to all the patches in this series to add this option >>to existing commands that take the positive pattern. > > OK, should I also describe the --no-exclude option? If you support it, yes. What does it do? --no-exclude:: Cancels all the `--exclude` options given so far on the command line. perhaps?