From: Junio C Hamano Date: Tue, 06 Mar 2012 00:57:33 GMT Subject: Re: [PATCH v3 04/11] parse_object: special code path for blobs to avoid putting whole object in memory Message-ID: <7vty22wnpe.fsf@alter.siamese.dyndns.org> In-Reply-To: <1330919028-6611-5-git-send-email-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy The code looks OK but the updated API into check_sha1_signature() needs to be explained both in-code comment and the log message. I'll push out an updated version later on 'pu'.