From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 04 Jul 2012 19:26:07 GMT
Subject: Re: [PATCH/RFC] Replace ce_namelen() with a ce_namelen field
Message-ID: <7vtxxns4z4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1341393528-21037-1-git-send-email-t.gummerer@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

> Replace the ce_namelen() function in cache.h with a ce_namelen
> field in struct cache_entry.

NAK, at least in this form that duplicates the same information in
ce_namelen (new field) and bits in ce_flags, making it easier for
them to go out of sync with new bugs (or misconversions in this
patch, if there is one).

At least, keep the ce_namelen() inline used in the existing calling
site, as the whole point of it is that they do not have to care how
the name length is stored or computed.