From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 01 Jan 2013 05:56:47 GMT
Subject: Re: [PATCH 1/8] Use %B for Split Subject/Body
Message-ID: <7vtxr1bg4g.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1357012655-24974-2-git-send-email-greened@obbligato.org>

"David A. Greene" <greened@obbligato.org> writes:

> From: Techlive Zheng <techlivezheng@gmail.com>
>
> Use %B to format the commit message and body to avoid an extra newline
> if a commit only has a subject line.

Is this an unconditional improvement, or is it generally an
improvement but for some users it may be a regression?  I am
guessing it is the former but am just making sure.

> Author:    Techlive Zheng <techlivezheng@gmail.com>
>
> Signed-off-by: David A. Greene <greened@obbligato.org>

Please don't do "Author: " which does not add anything new.  That is
what "From: " is for.  Instead it needs to be a sign-off.

Also, is that a real name, I have to wonder?

Thanks.