From: Junio C Hamano Date: Thu, 14 Feb 2013 21:51:26 GMT Subject: Re: [PATCH] Documentation: filter-branch env-filter example Message-ID: <7vtxpey36p.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130214210910.GA6660@sigill.intra.peff.net> Jeff King writes: > I think it has always been the case that we export them after setting > them; just look at the preimage from 3c730fab, and you can see exports > there. Yeah, I think the only difference is a broken commit case where sed expression did not find what it was looking for, in which case we do not do the export. > I think the advice in the documentation about re-exporting is because > some versions of the bourne shell will not reliably pass the new version > of the variable ... Ahh, old and painful memory of Solaris days comes back to me. OK, let's keep the export then. Thanks.