From: Junio C Hamano Date: Mon, 25 Feb 2013 07:14:40 GMT Subject: Re: [PATCH] Improve QNX support in GIT Message-ID: <7vtxp0zwyn.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vvc9h4d7c.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Mike Gorchak writes: > >> CFLAGS="-I/usr/qnxVVV/include" LDFLAGS="-I/usr/qnxVVV/lib" ./configure >> --prefix=/usr > > Oh, I didn't notice that, but the definition of ALL_CFLAGS may be > what is wrong. It allows CFLAGS to come before BASIC_CFLAGS that > adds -Icompat/, which goes against the whole point of having > replacement headers in compat/ directory. Also, in general, as the end-user input, we would want to make it take the precedence, so that CFLAGS can be used to override the default command line; e.g. we may have -DMACRO=value on BASIC_CFLAGS or others on ALL_CFLAGS, and let the users who know what they are doing use CFLAGS=-DMACRO=anothervalue to override it. Swapping the order between CFLAGS and BASIC_CFLAGS in ALL_CFLAGS may be a good change for that reason as well. In any case, I won't take a patch to rename source files left and right only to work around name collisions with random system header files we do not even use ourselves, unless/until I know we have tried all the other saner approaches first. That's a workaround, not a solution.