From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 03 Mar 2013 06:22:46 GMT
Subject: Re: [bug report] git-am applying maildir patches in reverse
Message-ID: <7vtxotc895.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m28v66198o.fsf@igel.home>

Andreas Schwab <schwab@linux-m68k.org> writes:

> You should always cast to unsigned char when determining the order of
> characters, to be consistent with strcmp/memcmp.

We treat runs of digits as numbers, so it is not even similar to
strcmp.  As long as it is internally consistent (i.e. the return
value inside the loop (*a - *b) must match the last return), it
should be OK, no?