From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 27 Mar 2013 15:04:38 GMT
Subject: Re: [PATCH 15/15] t7502: remove clear_config
Message-ID: <7vtxnwq3y1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <25d62be2c030306929dd11f92a7ac4be8b227ea1.1364158574.git.ydroneaud@opteya.com>

Yann Droneaud <ydroneaud@opteya.com> writes:

> Using test_config ensure the configuration variable are removed
> at the end of the test, there's no need to remove variable
> at the beginning of the test.
>
> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>

This is a good change in the longer term, but there must not be any
other topic in-flight that adds new tests that modify configuration
in a persistent way, which your previous patch based on 'master'
wouldn't have addressed, for this to be a safe change (I assume that
you already have checked that).

Otherwise these apparently redundant unsets need to be left as "belt
and suspenders" safety.  The same for the change to 4202 in [PATCH
07/15].

Thanks.