From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Apr 2013 21:21:23 GMT
Subject: Re: [PATCH v3 2/2] transport-helper: check if remote helper is alive
Message-ID: <7vtxngvhv0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130408211154.GA10310@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Apr 08, 2013 at 02:08:03PM -0700, Junio C Hamano wrote:
>
>> OK, so you are envisioning that transport-helper would read from the
>> helper after importer is done?  If so, perhaps it is a prudent
>> solution to disconnect in this version (to fix), and then in a
>> separate patch that adds such an extension (I imagine it would
>> involve that the helper advertising a capability or being invoked
>> with an option to let transport-helper somehow know that it should
>> continue the conversation once fast-import is done) to disable the
>> disconnect here when that extension is in use?
>
> At this point, I am of the opinion that it's OK to just do nothing;
> modern helpers should be using the "done" flag, and if they aren't, then
> that is the right place for the fix. Then we don't have to worry about
> any side effects of disconnecting, or adding a new capability flag.

Sounds sane.  Thanks for unconfusing me ;-)