From: Junio C Hamano Date: Mon, 15 Apr 2013 01:29:41 GMT Subject: Re: [PATCH 2/3] commit-slab: avoid large realloc Message-ID: <7vtxn84m4a.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130414191947.GB4599@sigill.intra.peff.net> Jeff King writes: > Yes, but isn't that a constant: > > (512*1024-32) / sizeof(struct commit_slab_piece) > > Leaving it as such lets the compiler optimize better, and is safe from > anybody changing it at runtime. But I think the answer to my question is > "yes, that would be the best thing for patch 2, but patch 3 will allow a > run-time stride parameter anyway". Correct? Yup.