From: Junio C Hamano Date: Mon, 13 May 2013 14:54:06 GMT Subject: Re: [PATCH v4 3/5] config: make parsing stack struct independent from actual data source Message-ID: <7vtxm7nd69.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130513140435.GC3561@book-mint> Heiko Voigt writes: > On Sun, May 12, 2013 at 09:56:39PM -0700, Junio C Hamano wrote: >> Heiko Voigt writes: >> >> > /* >> > - * The fields f and name of top need to be initialized before calling >> > + * All source specific fields in the union, name and the callbacks >> > + * fgetc, ungetc, ftell of top need to be initialized before calling >> > * this function. >> > */ >> > -static int do_config_from(struct config_file *top, config_fn_t fn, void *data) >> > +static int do_config_from_source(struct config_source *top, config_fn_t fn, void *data) >> >> This renaming may have made sense if we were to have many different >> do_config_from_$type functions for different types of source, but as >> this patch introduces a nice "config_source" abstraction, I do not >> think it is unnecessary. Shortening do_config_from() to do_config() >> may make more sense, if anything. >> >> But that is a very minor point, as this is entirely internal with a >> single caller. > > Did you really intent this double negation: "..., I do not think it > is unnecessary." Eh, rather "I think it is unnecessary" or "I do not think it is necessary".