From: Junio C Hamano <junkio@cox.net>
Date: Sat, 21 May 2005 02:11:24 GMT
Subject: Re: [PATCH] show changed tree objects with recursive git-diff-tree
Message-ID: <7vsm0hpbub.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.62.0505202131520.4397@localhost.localdomain>

Although I do not have immediate objections to what it tries to
do, I have to think about the intent of the patch and its
ramifications.

However, I think the patch operates at the wrong level if you
are basing on the tip of Linus tree.  With the new diff core,
you do not filter like this:

-		char *newbase = malloc_base(base, path1, pathlen1);
+		char *newbase;
+		if (!silent && !generate_patch)
+			diff_change(mode1, mode2, sha1, sha2, base, path1);
+		newbase = malloc_base(base, path1, pathlen1);

I'd just say "if (!silent)" there.  The updated diff_change
_should_ do the right thing regardless of generate_patch value
you have there, because it is already told about it with
diff_setup(), and it knows not to say silly things when we are
generating patch.