From: Junio C Hamano Date: Sat, 29 Oct 2005 02:49:18 GMT Subject: Re: gitk shows an empty line between "Comments" and changed files Message-ID: <7vslul2g29.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <1130539503.10531.43.camel@dv> Pavel Roskin writes: >> git-rev-list ^$old_head $new_head | >> git-diff-tree -p -m --stdin --with-commit-ids | >> git-patch-id > > Sounds good. Perhaps the commit IDs should have a prefix identifying > them. I do not think git-diff-tree -p output can have 40-byte hexadecimal at the beginning of the output anywhere other than commit object names; why clutter output? > Another approach would be to use something slightly more elaborate than > a pipe. If I understand correctly, the commit ID would be already known > from the git-rev-list output. Passing commit IDs through patch-id > without actually doing anything with them seems non-elegant. Sorry you lost me. I am not sure what you mean by "without actually doing anything" part. The input to patch-id command in the above pipe is (commit-object-name patch)*. The command reads such a stream, and transforms it to a (patch-id commit-object-name)* stream. In other words, the input identifies each patch with a commit-object-name, and the command condenses each patch to a patch-id, and spits them out, labelled with commit-object-name.