From: Junio C Hamano Date: Wed, 25 Oct 2006 04:46:37 GMT Subject: Re: [PATCH] Fix bad usage of mkpath in builtin-branch.sh Message-ID: <7vslhddmtu.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7vac3lf3jl.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Petr Baudis writes: > >> I have made my fair share of inadverent mode changes as well (I don't >> even know how that *happenned*), and I don't seem to be alone; since >> this is something you are doing only rarely anyway, perhaps we should >> try to make mode changes more visible? > > Well we already do and that's how I noticed. Ah, sorry, I think I misunderstood you. Did you mean something like this? diff --git a/git-commit.sh b/git-commit.sh index 5b1cf85..8bae734 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -629,4 +629,7 @@ if test -x "$GIT_DIR"/hooks/post-commit then "$GIT_DIR"/hooks/post-commit fi + +test "$ret" = 0 && git-diff-tree --summary --root --no-commit-id HEAD + exit "$ret"