From: Junio C Hamano <junkio@cox.net>
Date: Tue, 27 Feb 2007 23:56:38 GMT
Subject: Re: [PATCH] cvsserver: Make always-binary mode a config file option
Message-ID: <7vslcr9mtl.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200702271346.55520.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

> +    unless ( defined ( $cfg->{gitcvs}{allbinary} ) and $cfg->{gitcvs}{allbinary} =~ /^\s*(1|true|yes)\s*$/i )
> +    {
> +		# Return "" to give no special treatment to any path
> +		return "";
> +    } else {
> +		# Alternatively, to have all files treated as if they are binary (which
> +		# is more like git itself), always return the "-kb" option
> +		return "-kb";
> +    }
> +}

This is not your fault as you copied existing code to check
boolean, but I am unhappy every time I see "git-config -l"
forces such an eyesore on us X-<.

Anyway, will apply.  Thanks.