From: Junio C Hamano Date: Sat, 07 Jul 2007 20:36:17 GMT Subject: Re: [PATCH] Per-path attribute based hunk header selection. Message-ID: <7vsl806jem.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: >> Johannes, it strikes me that it is very odd having to add ".*$" at the >> end and to surround the whole thing in a parentheses. Shouldn't the >> ff_regexp() grabber simply pick the whole line? After all, that is what >> GNU "diff -p -F RE" does. > > Yes, but then you can forget about your hierarchical idea. Yeah, I've brought it up just for discussion, but I no longer think the multi-line pattern that picks pieces and paste them together is worth it.