From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Nov 2007 10:37:34 GMT
Subject: Re: [PATCH] Add line-wrapping guidelines to the coding style documentation
Message-ID: <7vsl39i041.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <56A87A65-3C2E-4E10-84D4-4470879EE466@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:

> A statistician could probably make some interesting comments about the  
> results, but the basic trend is that, while there are plenty of  
> examples of isolated long lines in the source tree (the longest is a  
> 287-character line in one of the perl scripts), the frequency starts  
> to drop off pretty rapidly once you pass 70 columns and start climbing  
> towards 80.

Gaah.  287???

> + - In the case of documentation, mixing excessively long and short
> +   lines may make the AsciiDoc source harder to read, so try to
> +   keep line lengths consistent.
> +
> + - When submitting patches use common sense to decide whether to
> +   rewrap, avoiding gratuitous changes.

Hmph.  The last item applies only to the documentation because
it uses the word "rewrap", but otherwise applies equally well to
the sources (re-indenting).  So probably "whether to rewrap or
reindent" would be a good change there.