From: Junio C Hamano Date: Tue, 11 Dec 2007 08:02:09 GMT Subject: Re: [PATCH] Brown paper bag fix to previous send-email change Message-ID: <7vsl29fym6.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071211074427.GA12959@glandium.org> Mike Hommey writes: > On Mon, Dec 10, 2007 at 11:04:36PM -0800, Junio C Hamano wrote: >> Mike Hommey writes: >> >> > My previous change led to the In-Reply-To header being <> when the given >> > value was empty. This fixes it. >> > >> > Signed-off-by: Mike Hommey >> > --- >> > >> > I think I have an antispam problem somewhere with this patch, because even >> > keeping sending it, it never reached the list. And Junio didn't answer to my >> > private message about it, so I guess that was some server being smart with >> > the subject line. *sigh* >> > >> > PS: sorry Junio if you get this patch multiple time. >> >> No, I happened to have noticed the same and have an almost identical fix >> (I said "defined $initial_reply_to") already queued in my tree. > > Testing "defined $initial_reply_to" might not be enough, because $initial_reply_to > can be defined and empty. And if empty what does your regexp do? Produce "<>"? How's that useful?