From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Dec 2007 00:55:47 GMT
Subject: Re: [PATCH 5/5] Add tests for "git diff --check" with core.whitespace options
Message-ID: <7vsl26xffw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1197552751-53480-6-git-send-email-win@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:

> +test_expect_success 'check spaces as indentation (indent-with-non-tab: off)' '
> +
> +	git config core.whitespace "-indent-with-non-tab"
> +	echo "                foo ();" > x &&
> +	git diff --check
> +
> +'
> +
> +test_expect_failure 'check spaces as indentation (indent-with-non-tab: on)' '
> +
> +	git config core.whitespace "indent-with-non-tab" &&
> +	echo "                foo ();" > x &&
> +	git diff --check
> +
> +'
> +
>  test_done

It is good to check both positive and negative cases, but I would prefer
avoiding test_expect_failure.  You cannot tell if the "git config"
before the real test failed or "git diff --check" correctly reported
whitespace breakage --- both would cause the test to pass.