From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 26 Aug 2008 17:38:35 GMT
Subject: Re: [PATCH] be paranoid about closed stdin/stdout/stderr
Message-ID: <7vsksrad7o.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <48B3A948.3080800@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Paolo Bonzini schrieb:
>> +	/*
>> +	 * Always open file descriptors 0/1/2 to avoid clobbering files
>> +	 * in die().  It also avoids not messing up when the pipes are
>> +	 * dup'ed onto stdin/stdout/stderr in the child processes we spawn.
>> +	 */
>
> I see your point, but I don't have an opinion whether this stretch is
> necessary.

This is going too far.  Have you seen any other sane program that do this?