From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Sep 2009 05:55:52 GMT
Subject: Re: [PATCH 2/4] reset: use "unpack_trees()" directly instead of "git read-tree"
Message-ID: <7vskeu10uv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200909110734.13903.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> On Friday 11 September 2009, Junio C Hamano wrote:
>> Christian Couder <chriscool@tuxfamily.org> writes:
>> > From: Stephan Beyer <s-beyer@gmx.net>
>> >
>> > This patch makes "reset_index_file()" call "unpack_trees()" directly
>> > instead of forking and execing "git read-tree".
>>
>> And the reason why it is a good idea is...?
>
> ...that it should be faster.
>
> Ok, I will add that to the commit message in the next version.

Please don't add "should be".  That is not a justification.