From: Junio C Hamano Date: Mon, 01 Feb 2010 23:44:49 GMT Subject: Re: [PATCH] resolve-undo.c: silence compiler complaints by casting void * to char * Message-ID: <7vsk9kplla.fsf@alter.siamese.dyndns.org> In-Reply-To: Thanks for catching this. In this particular case, I however suspect that it would be cleaner to declare that the first parameter to resolve_undo_read() is a "char *" (or even "const char *"), as we are dealing with NUL delimited list of octal numbers and character strings.