From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Aug 2010 07:34:13 GMT
Subject: Re: [PATCH 2/2] Submodules: Add the new "fetch" config option
Message-ID: <7vsk1wftai.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C7A81F0.4090209@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> diff --git a/submodule.c b/submodule.c
> index e4f2419..8c98fad 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -100,6 +101,14 @@ int parse_submodule_config_option(const char *var, const char *value)
>  			config = string_list_append(&config_name_for_path, xstrdup(value));
>  		config->util = strbuf_detach(&submodname, NULL);
>  		strbuf_release(&submodname);
> +	} else if ((len > 5) && !strcmp(var + len - 6, ".fetch")) {
> +		strbuf_add(&submodname, var, len - 6);
> +		config = unsorted_string_list_lookup(&config_fetch_for_name, submodname.buf);
> +		if (!config)
> +			config = string_list_append(&config_fetch_for_name,
> +						    strbuf_detach(&submodname, NULL));
> +		config->util = (void *)git_config_bool(var, value);

Hmm?  We get this here...

    submodule.c:110: error: cast to pointer from integer of different size