From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 23 Mar 2011 05:46:03 GMT
Subject: Re: [PULL svn-fe] vcs-svn: simplifications, error handling improvements
Message-ID: <7vsjuegzj8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110323003240.GA4949@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Please pull
>
>   git://repo.or.cz/git/jrn.git svn-fe
>
> to get the following changes on top of master.

Done.

I only gave a cursory look at "git diff ORIG_HEAD" output immediately
after pulling, but I found that the majority of lines deleted were of
questionable style and the added ones looked more like normal C ;-)

Except for

	switch (keylen + 1) {
        case sizeof("constant string"):
        	...
                break;
        case sizeof("another constant string"):
        	...
	}

which looked a bit unusual. But mistakes in this construct can be easily
caught by the compiler that would notice duplicated case labels, so it
probably is not so brittle as it first looks.

By the way, I've been getting annoyed by these three "sleep 100" getting
stuck in t0081 and spending their sweet timeout while running my tests
(prove is on, "make test </dev/null" to forbid it from reading my stdin).
I see attempts to kill them early with "kill $!" but apparently they are
not working. Can you take a look at it?