From: Junio C Hamano Date: Mon, 09 May 2011 23:56:20 GMT Subject: Re: [PATCH v3 0/3] Git commit --patch (again) Message-ID: <7vsjsnmnrv.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vwrhzmnxf.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Jeff King writes: > >> It's unfortunately not quite as simple as having that test succeed, as >> it changes state that breaks later tests. I didn't investigate deeply, >> though. > > Yeah, that test that hardcodes the exact commit sequence is disgusting. > In the meantime... > > -- >8 -- > From: Jeff King > Subject: [PATCH] t7501.8: feed a meaningful command And then on top of that, Conrad's "allow commit --interactive " would come, with this squashed in. The last "reset HEAD^" is nasty but I don't have enough energy to fix 12ace0b (Add test case for basic commit functionality., 2007-07-31) today. t/t7501-commit.sh | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh index 3d2b14d..c2fd116 100755 --- a/t/t7501-commit.sh +++ b/t/t7501-commit.sh @@ -41,11 +41,12 @@ test_expect_success \ "echo King of the bongo >file && test_must_fail git commit -m foo -a file" -test_expect_success PERL 'cannot use paths with --interactive' ' +test_expect_success PERL 'can use paths with --interactive' ' echo bong-o-bong >file && # 2: update, 1:st path, that is all, 7: quit ( echo 2; echo 1; echo; echo 7 ) | - test_must_fail git commit -m foo --interactive file + git commit -m foo --interactive file && + git reset --hard HEAD^ ' test_expect_success \