From: Junio C Hamano Date: Thu, 19 May 2011 14:17:27 GMT Subject: Re: [PATCHv2] add Android support Message-ID: <7vsjsa93m0.fsf@alter.siamese.dyndns.org> In-Reply-To: <2218C353-80FC-4540-A60E-608385384FB5@gieschke.de> Rafael Gieschke writes: >> (3) Add uname_S = Android (Makefile). >> >> The first two would become much easier to justify if presented that >> way. At least you won't hear from anybody "we don't want that much code to >> not to run git on a phone!", as it is not entirely implausible to imagine >> environments without support for one or both of these two facilities. > > So, you would prefer to leave out ANDROID and use something like "ifeq > ($(uname_S),Android)", so you will have to compile using make > uname_S=Android? I would be fine with that, too. But I would also be > fine with having to specify the build options on the command line or > using a config.mak if you want to keep Android out of the Makefile. Ignore differences s/Android/ANDROID/; I just typed differently without even noticing I was doing so (the same for GECOS-PWENT but if you liked my name better that is fine by me as well). The point is that I didn't mean to suggest changing names of symbols you used.