From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Jun 2011 15:58:41 GMT
Subject: Re: [RFC/PATCH 0/7] user-configurable git-archive output formats
Message-ID: <7vsjr4cx5a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4DFCBB92.5040308@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> I'm not sure "filter" is a good name, though.  We have core.pager, which
> is technically a filter as well, but for a specific purpose.  And we
> have the tar.umask setting as a precedence for format specfic config
> options.  So how about tar.<extension>.compressor?
>
> 	[tar "tgz"]
> 		compressor = gzip -cn
> 	[tar "tar.gz"]
> 		compressor = gzip -cn
> 	[tar "tar.bz2"]
> 		compressor = bzip2 -c
>
> We don't need a compressionlevels option here because we can simply
> assume that the compressor commands do support them.  (Side note: this
> is not fully true for bzip2, as it doesn't support -0, but I don't think
> this is worth special consideration in our code, as long as errors of
> the filter are displayed properly.)
>
> And we can also add a config option to restrict the formats creatable by
> upload-archive, to address concerns over DoS attacks with expensive
> compressors:
>
> 	[archive]
> 		remoteFormats = tar zip tgz tar.gz

Both sounds sensible, I think.