From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Oct 2011 18:14:55 GMT
Subject: Re: [PATCH 2/2] bundle: add parse_bundle_header() helper function
Message-ID: <7vsjmvzbhc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CABURp0otqxeKjLe-Rk3htZRa0M7+rerfrbVrXx-7Dr1tK3tTTg@mail.gmail.com>

Phil Hord <phil.hord@gmail.com> writes:

> On Thu, Oct 13, 2011 at 6:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Move most of the code from read_bundle_header() to parse_bundle_header()
>> that takes a file descriptor that is already opened for reading, and make
>> the former responsible only for opening the file and noticing errors.
> ...
>
>>  * It generally is a bad practice to base a non-RFC patch on an RFC one,
>>   but in any case here is how I would do the is_bundle() helper.
>
> I didn't label it RFC,...

I was referring to the fact that _my_ 2/2 you are responding to was meant
to be applied on top of _my_ 1/2 that was marked as RFC.