From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Apr 2012 18:22:46 GMT
Subject: Re: [PATCH 02/12] completion: simplify __gitcomp
Message-ID: <7vsjgcwyrt.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120408143912.GB2631@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> (-cc: Shawn)
> Felipe Contreras wrote:
>
>> I've looked at the history of __gitcomp and __gitcomp_nl, now I think
>> it makes sense to keep their arguments similar, at least for the time
>> being.
>>
>> So I suggest this patch to be dropped.
>
> Thanks for looking into it, and sorry I responded to a heated response
> instead of waiting for a calmer one.

Good to see a civilized discussion of patches on technical merits.

Thanks.