From: Junio C Hamano Date: Mon, 06 Aug 2012 17:03:37 GMT Subject: Re: [PATCH] read_index_from: remove bogus errno assignments Message-ID: <7vsjc0ymty.fsf@alter.siamese.dyndns.org> In-Reply-To: <1344252429-7377-1-git-send-email-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > While at it, move die_errno() next to xmmap() call because it's the > mmap's error code that we care about. Otherwise if close(fd); fails, > it could overwrite mmap's errno. Makes sense and is a sensible fix. Thanks.