From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 26 Feb 2013 21:44:08 GMT
Subject: Re: [PATCH] diff: prevent pprint_rename from underrunning input
Message-ID: <7vsj4ilphz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <d74fcfa693e5feb7249023feda8d3ad1f22ab16d.1361911196.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

> The logic described in d020e27 (diff: Fix rename pretty-print when
> suffix and prefix overlap, 2013-02-23) is wrong: The proof in the
> comment is valid only if both strings are the same length.  *One* of
> old/new can reach a-1 (b-1, resp.) if 'a' is a suffix of 'b' (or vice
> versa).

Thanks.  I was also having hard time convincing myself why that -1
does not under-run yesterday.

Will queue.