From: Junio C Hamano Date: Tue, 09 Apr 2013 19:10:04 GMT Subject: Re: [PATCH 2/2] add: refuse to add paths beyond repository boundaries Message-ID: <7vsj2zr04z.fsf@alter.siamese.dyndns.org> In-Reply-To: <516464E4.10503@gmail.com> Jakub Narębski writes: > Junio C Hamano wrote: >> Jakub Narębski writes: >> >>> W dniu 09.04.2013 19:34, Junio C Hamano pisze: >>> >>>> - if (has_symlink_leading_path(path, len)) >>>> - return error("'%s' is beyond a symbolic link", path); >>>> + if (path_outside_our_project(path, len)) >>>> + return error("'%s' is outside our working tree", path); >>>> >>> >>> Don't we lose important information here? Or we shouldn't care? >> >> What important information is it? > > That the cause is symbolic link (or other git repository, in the future). And in what way is it important?