From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 14 Apr 2013 06:55:42 GMT
Subject: Re: [PATCH v2 1/3] Add public function read_blob_data_from_index_path()
Message-ID: <7vsj2t61ox.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vwqs56418.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> diff --git a/attr.c b/attr.c
> index a668a63..46bde57 100644
> --- a/attr.c
> +++ b/attr.c
> @@ -387,7 +387,7 @@ static struct attr_stack *read_attr_from_index(const char *path, int macro_ok)
>  	char *buf, *sp;
>  	int lineno = 0;
>  
> -	buf = read_blob_data_from_index_path(path, use_index);
> +	buf = read_blob_data_from_index(use_index, path);

This was wrong.

The one I'll push out will have:

	buf = read_blob_data_from_index(use_index ? use_index : &the_index, path);