From: Junio C Hamano Date: Mon, 20 May 2013 22:36:58 GMT Subject: Re: [PATCH] contrib/git-subtree: Use /bin/sh interpreter instead of /bin/bash Message-ID: <7vsj1hth11.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130520202434.GA3151@hades.panopticon> Dmitry Marakasov writes: > Use /bin/sh interpreter instead of /bin/bash for contrib/git-subtree: > it's required for systems which don't use bash by default (for example, > FreeBSD), while there seem to be no bashisms in the script (confirmed > by looking through the source and tesing subtree functionality with > FreeBSD's /bin/sh) to require specifically bash and not the generic > posix shell. Has anybody audited to make sure that the script itself is free of bash-isms? I somehow had an impression that in the past it was littered with bash-isms like function local variables and array variables and assumed that the #!/bin/bash was necessary. I did a quick eyeballing and did not see anything glaringly bash-only, but I may have missed something (the coding style is so different from the core part of Git Porcelains and distracting for me to efficiently do a good job of scanning). > > Signed-off-by: Dmitry Marakasov > --- > contrib/subtree/git-subtree.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh > index 8a23f58..5701376 100755 > --- a/contrib/subtree/git-subtree.sh > +++ b/contrib/subtree/git-subtree.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/bin/sh > # > # git-subtree.sh: split/join git repositories in subdirectories of this one > #