From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Jun 2013 19:01:11 GMT
Subject: Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style
Message-ID: <7vsj0phjt4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqa9mxeuvf.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Please, don't top-post. Quote the part of the message you're replying
> to, and reply below.
>
> Benoît Person <benoit.person@ensimag.fr> writes:
>
>> Well, I think next step would be to replace all those calls with
>> Git.pm `command`, `command_oneline` and `config``which take an array
>> of arguments after the "command". In the preview tool we use those but
>> I don't know if we will find the time to clean that up too in
>> git-remote-mediawiki :) .
>
> Agreed. run_git was written to avoid having to depend on Git.pm, but now
> that we do, we should do it the Git.pm way (although this is not a
> high priority for now).
>
>> Don't know though if it's better to mix that with this serie which is
>> mainly based on what perlcritic returns.
>
> If you go this way, I'd rather have it on top (i.e. a separate patch
> series).

Or not worry too much about it in the 3-week long school project.
Finish one that you started and then build on top.