From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Jun 2013 16:48:28 GMT
Subject: Re: [PATCH v2 00/13] bash prompt speedup
Message-ID: <7vsj0f5pr7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1371521826-3225-1-git-send-email-szeder@ira.uka.de>

SZEDER Gábor <szeder@ira.uka.de> writes:

> This patch series eliminates many command substitutions and commands
> in __git_ps1() from top to bottom by replacing them with bash builtins
> or consolidating them.  A few timing results are shown in the log
> message of patch 10.

Nice.  I think I saw Peff's comment and discussion between you two
already resuted in a fixup, so perhaps I'll see a reroll sometime
later when the dust settles?

Also, could you help review the other topic by Eduardo R. D'Avila
about colored prompt (Sion Oosthoek, who did the color support,
CC'ed)?

    http://thread.gmane.org/gmane.comp.version-control.git/228017

The impression I got when the PROMPT_COMMAND series was discussed
last October was that you need to use \[...\] pairs to get the
cursor position right for the purpose of command line editing, and
D'Avila's series seemed to only do so in PROMPT_COMMAND mode.