From: Junio C Hamano <junkio@cox.net>
Date: Tue, 01 Aug 2006 09:50:12 GMT
Subject: Re: [PATCH 1/2] Use tabs for indent in shell scripts
Message-ID: <7vr70023aj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200608011134.52006.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

>  if [ -n "$GIT_SSL_NO_VERIFY" ]; then
> -    curl_extra_args="-k"
> +	curl_extra_args="-k"
>  fi

Things like this makes some sense...

>  		if test -n "$use_separate_remote" &&
> -		   branch_name=`expr "z$name" : 'zheads/\(.*\)'`
> +			branch_name=`expr "z$name" : 'zheads/\(.*\)'`
>  		then

... but not this, which is not just indent but an alignment.

>  		case "$2" in
>  		'')
> -		    usage ;;
> +			usage ;;
>  		*/*)
> -		    echo >&2 "'$2' is not suitable for an origin name"
> -		    exit 1
> +			echo >&2 "'$2' is not suitable for an origin name"
> +			exit 1

Also shell scripts tend to become too deeply indented, and 4-column
indentation helps to keep things within typical screen width.

In short, not very enthused.