From: Junio C Hamano <junkio@cox.net>
Date: Sat, 12 Aug 2006 23:09:11 GMT
Subject: Re: [PATCH] make git compile on old version of engarde linux
Message-ID: <7vr6zlo8ko.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060812224520.GB13704@mellanox.co.il>

"Michael S. Tsirkin" <mst@mellanox.co.il> writes:

>> Alternatively Ramsay's _XOPEN_SOURCE patch is part of "next", so
>> if it fixes the problem for you that would confirm the patch is
>> a good one to have.
>
> BTW, would it make sense fr this patch to be cherry-picked into 1.4.8?
> I guess the reason that LNK macros are under GNU_SOURCE is the following
> text from stat(2):
>  
>        The S_ISLNK and S_ISSOCK macros
>        are not in POSIX.1-1996, but both will be in the next  POSIX  standard;
>        the former is from SVID 4v2, the latter from SUSv2.

I originally scheduled it for immediately after 1.4.2 but I
would say why not.  It makes sense and does not seem to break
for people (otherwise I would have heard screams, hopefully).