From: Junio C Hamano Date: Tue, 24 Oct 2006 06:46:48 GMT Subject: Re: [PATCH] git-send-email: do not pass custom Date: header Message-ID: <7vr6wyqkh3.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20061023093824.GB8749@localdomain> Eric Wong writes: > Jakub Narebski wrote: >> Eric Wong wrote: >> >> > We already generate a Date: header based on when the patch was >> > emailed. ?git-format-patch includes the Date: header of the >> > patch. ?Having two Date: headers is just confusing, so we >> > just use the current Date: >> > >> > Often the mailed patches in a patch series are created over a >> > series of several hours or days, so the Date: header from the >> > original commit is incorrect for email, and often far off enough >> > for spam filters to complain. >> >> But that makes us lose original commit date. And git format-patch >> is if I remember correctly together with git-am used in git-rebase. > > This patch is for git-send-email, and only affects the way they > are sent over SMTP. Output of git-format-patch is unchanged. An alternative to satisfy both (Jakub wants original author date propagated to the recipient of the e-mail who will run "git-am" to apply the patch; you do not want to throw potentially ancient author date as the e-mail's Date: to SMTP layer) is to use sending date in e-mail header (like your patch does) _and_ leave the Date: header for the original author date as the first line of the e-mail message, separated with the real body of the message with a blank line.