From: Junio C Hamano <junkio@cox.net>
Date: Thu, 26 Oct 2006 17:21:53 GMT
Subject: Re: [PATCH] gitweb: Check git base URLs before generating URL from it
Message-ID: <7vr6wvkn66.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200610261226.44960.jnareb@gmail.com>

Wouldn't this be simpler and more to the point, I wonder?

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 5a81b8f..aceaeb7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -80,7 +80,7 @@ our $strict_export = "++GITWEB_STRICT_EX
 
 # list of git base URLs used for URL to where fetch project from,
 # i.e. full URL is "$git_base_url/$project"
-our @git_base_url_list = ("++GITWEB_BASE_URL++");
+our @git_base_url_list = grep { $_ ne '' } ("++GITWEB_BASE_URL++");
 
 # default blob_plain mimetype and default charset for text/plain blob
 our $default_blob_plain_mimetype = 'text/plain';